http: fix read_file on win32 (wrong filesize) and use mbuf #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2023
|
reading a file into a buffer (mbuf or byte buffer) is quite generic perhaps it is better to place the function in the SYS module ? |
fAuernigg
force-pushed
the
fix_readfile_on_win32
branch
5 times, most recently
from
324a07f
to
14056e2
Compare
Is current approach ok now in sys module? |
sreimers
reviewed
Mar 1, 2023
fAuernigg
force-pushed
the
fix_readfile_on_win32
branch
from
14056e2
to
53f600f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.