Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vidmix: coverity fix #830

Merged
merged 1 commit into from
Jun 4, 2023
Merged

vidmix: coverity fix #830

merged 1 commit into from
Jun 4, 2023

Commits on Jun 3, 2023

  1. vidmix: coverity fix

    New defect(s) Reported-by: Coverity Scan
    Showing 12 of 12 defect(s)
    
    ** CID 462177:  Concurrent data access violations  (MISSING_LOCK)
    /rem/vidmix/vidmix.c: 71 in clear_all()
    
    ________________________________________________________________________________________________________
    *** CID 462177:  Concurrent data access violations  (MISSING_LOCK)
    /rem/vidmix/vidmix.c: 71 in clear_all()
    65     	struct le *le;
    66
    67     	for (le=mix->srcl.head; le; le=le->next) {
    68
    69     		struct vidmix_source *src = le->data;
    70
    >>>     CID 462177:  Concurrent data access violations  (MISSING_LOCK)
    >>>     Accessing "src->clear" without holding lock "vidmix_source.mutex". Elsewhere, "vidmix_source.clear" is accessed with "vidmix_source.mutex" held 5 out of 6 times.
    71     		src->clear = true;
    72     	}
    73     }
    74
    75
    76     static void destructor(void *arg)
    
    ** CID 462176:  Concurrent data access violations  (MISSING_LOCK)
    /rem/aubuf/ajb.c: 155 in ajb_alloc()
    alfredh committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    40bf120 View commit details
    Browse the repository at this point in the history