Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: more generic function to set cafile and capath #84

Merged
merged 5 commits into from
Mar 18, 2021

Conversation

cHuberCoffee
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #84 (dd3e5ec) into master (95c31d9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head dd3e5ec differs from pull request most recent head 0acc49e. Consider uploading reports for the commit 0acc49e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   53.24%   53.35%   +0.10%     
==========================================
  Files         192      192              
  Lines       21459    21475      +16     
==========================================
+ Hits        11425    11457      +32     
+ Misses      10034    10018      -16     
Impacted Files Coverage Δ
src/sys/fs.c 30.76% <100.00%> (+30.76%) ⬆️
src/tls/openssl/tls.c 29.20% <100.00%> (+1.54%) ⬆️
src/mbuf/mbuf.c 78.48% <0.00%> (-0.59%) ⬇️
src/main/main.c 55.04% <0.00%> (+0.12%) ⬆️
src/sip/strans.c 39.58% <0.00%> (+4.16%) ⬆️
src/dbg/dbg.c 42.59% <0.00%> (+5.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c31d9...0acc49e. Read the comment docs.

src/tls/openssl/tls.c Outdated Show resolved Hide resolved
src/tls/openssl/tls.c Show resolved Hide resolved
src/tls/openssl/tls.c Outdated Show resolved Hide resolved
@juha-h
Copy link
Contributor

juha-h commented Mar 17, 2021

These should be improved:

 * @param cafile PEM file with CA certificate
 * @param capath Path containing CA certificates

Isn't it so that also cafile file can contain many ca certificates?

Path does not contain ca certificates, but files than contain ca certificates.

@sreimers sreimers merged commit 9a5ff1c into baresip:master Mar 18, 2021
@cHuberCoffee cHuberCoffee deleted the tls_capath branch March 18, 2021 14:37
@sreimers sreimers added the enhancement New feature or request label Apr 9, 2021
@sreimers sreimers added this to the v2.0.0 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants