sip: fix TCP source port #921
Conversation
The TCP source has at the `struct sip` has to be set before the TCP connection is opened. This commit fixes an issue that was introduced with 5c709fc which postponed the call to the `send_handler()` after the TCP connection is established.
cspiel1
force-pushed
the
main_sip_tcp_srcport
branch
from
e0d064d
to
e022495
Compare
| @@ -618,10 +611,13 @@ int sipreg_set_fbregint(struct sipreg *reg, uint32_t fbregint) | |||
| */ | |||
| void sipreg_set_srcport(struct sipreg *reg, uint16_t srcport) | |||
| { | |||
| if (!reg) | |||
| if (!reg || !reg->dlg) | |||
There was a problem hiding this comment.
Is setting the srcport only relevant for dlg? Or is there a use-case without it too?
There was a problem hiding this comment.
Currently not. We could add a setter void sip_request_set_srcport(...).
For now I couldn't find any call to plain sip_request() in re or baresip. And no call to sip_request_alloc() followed by sip_request_send().
For sipreg I think this is a correct condition, because it always has a dialog.
There was a problem hiding this comment.
Just saw that sip_request_alloc() is not in the API. So a setter sip_request_set_srcport() doesn't make sense.
There was a problem hiding this comment.
Maybe a bit misleading, I think the check !reg->dlg is not needed since it's not relevant for setting reg->srcport = srcport. As a caller of public sipreg_set_srcport I assume that srcport is set if I provide a valid sipreg object.
sip_dialog_set_srcport has a extra check for valid dlg, so this should fine.
The TCP source has at the
struct siphas to be set before the TCP connectionis opened. This commit fixes an issue that was introduced with
5c709fc which postponed the call to the
send_handler()after the TCP connection is established.