Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

pkgconfig missing when building using cmake #90

Closed
robert-scheck opened this issue Sep 28, 2022 · 1 comment
Closed

pkgconfig missing when building using cmake #90

robert-scheck opened this issue Sep 28, 2022 · 1 comment

Comments

@robert-scheck
Copy link
Contributor

When building using make, there is a librem.pc pkgconfig, but none when using cmake.

@robert-scheck
Copy link
Contributor Author

Building baresip HEAD fails like this when using packaged re and rem HEAD (which were both built using cmake):

/usr/bin/cmake -S . -B redhat-linux-build -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON
-- The C compiler identification is GNU 12.2.1
-- The CXX compiler identification is GNU 12.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found RE: /usr/lib64/libre.so  
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find REM (missing: REM_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindREM.cmake:12 (find_package_handle_standard_args)
  CMakeLists.txt:27 (find_package)

I'm no cmake expert, but it seems like baresip/cmake/FindREM.cmake just uses pkgconfig itself outside the CI.

cspiel1 added a commit that referenced this issue Oct 1, 2022
* cmake: bump min. version 3.10 (#79)

* auframe: auframe_bytes_to_timestamp use uint64_t

The correct type for timestamp is `uint64_t`.

* ci: migrate from make to CMake (#81)

* cmake: install improvements (#83)

* cmake: add static and shared targets (#84)

* cmake: add win32 linklibs (#85)

* update copyright/license

* debian: use dh-cmake (#86)

* debian: release build

* vid/frame: fix possbile overflow multiplication (#87)

Found by CodeQL: Multiplication result may overflow 'unsigned int'
before it is converted to 'size_t'.

* cmake: add pkgconfig (fixes #90) (#91)

* cmake/pkgconfig: fix name

* cmake: fix shared API soversion (aligned with make) (#89)

* release v2.8.0 (#92)

Co-authored-by: Sebastian Reimers <hallo@studio-link.de>
Co-authored-by: Alfred E. Heggestad <alfred.heggestad@gmail.com>
Co-authored-by: Robert Scheck <robert-scheck@users.noreply.github.com>
sreimers added a commit that referenced this issue Nov 1, 2022
* cmake: bump min. version 3.10 (#79)

* auframe: auframe_bytes_to_timestamp use uint64_t

The correct type for timestamp is `uint64_t`.

* ci: migrate from make to CMake (#81)

* cmake: install improvements (#83)

* cmake: add static and shared targets (#84)

* cmake: add win32 linklibs (#85)

* update copyright/license

* debian: use dh-cmake (#86)

* debian: release build

* vid/frame: fix possbile overflow multiplication (#87)

Found by CodeQL: Multiplication result may overflow 'unsigned int'
before it is converted to 'size_t'.

* cmake: add pkgconfig (fixes #90) (#91)

* cmake/pkgconfig: fix name

* cmake: fix shared API soversion (aligned with make) (#89)

* release v2.8.0 (#92)

* cmake: add pre-release version handling (#95)

* cmake,mk: bump dev version

* README.md: Update build instructions for cmake (#96)

* aubuf: exclude non compatible CXX functions (#97)

* auframe: skip level calculation if format is RAW (#99)

* ci: use actions/checkout@v3 (#101)

* vidframe_draw_point: add NV12 and NV21 pixel format (#102)

* prepare 2.9.0 (#104)

* version 2.9.0

Co-authored-by: Sebastian Reimers <hallo@studio-link.de>
Co-authored-by: Christian Spielberger <c.spielberger@commend.com>
Co-authored-by: Robert Scheck <robert-scheck@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant