Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

fix audio multicast artefacts #42

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Apr 27, 2022

auframe: add util function calc_nsamp()

@sreimers
Copy link
Member

I wonder if rem_au.h and something like src/au/util.c is a better place for this.

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Apr 27, 2022

I also thought about this. Then I thought calc_nsamp() has something to do with audio frames. It computes sampc for one audio frame. Anyway, do you prefer util.c?

@sreimers
Copy link
Member

sreimers commented Apr 27, 2022

It feels more generic to me. At the moment all auframe functions are related to the auframe struct (object). Having a place for generic audio helpers/utilities feels a little better. Maybe we add a function like auframe_nsamp(auframe af, uint16_t ptime) in future.

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Apr 27, 2022

You may still choose. Added a util.c. The last commit could be dropped, or we take it.

@sreimers sreimers merged commit 38ab363 into baresip:main Apr 27, 2022
@cspiel1 cspiel1 deleted the audio_multicast_cracks branch April 27, 2022 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants