[SPIKE-43288] Possible GemMQ Performance improvements #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved _publish method as class method to BarkMQ::Publisher module: Example: `BarkMQ::Publisher.publish(topic_name, message)` - improved performance of `publish` method by caching topic_arn instead of calling all the time `create_topic` of aws library.
ghost
closed this
ghost
deleted the
refactor/SPIKE-43288-duplicate-calls-on-topic-create
branch
ghost
restored the
refactor/SPIKE-43288-duplicate-calls-on-topic-create
branch
ghost
locked and limited conversation to collaborators
ghost
reopened this
ghost
closed this
ghost
reopened this
ghost
changed the title
ghost
closed this
ghost
reopened this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved
_publish methodas class method to BarkMQ::Publisher module:Example:
BarkMQ::Publisher.publish(topic_name, message). Previously it was defined in multiple placesasyncandworkerpublishers.improved performance of
publishmethod by cachingtopic_arninstead ofcalling all the time
create_topicof aws library. NowBarkMQ.publisher_configcontainstopic_arnsas cached arn names. Introduced the new methodBarkMQ.publisher_config.fetch_topic_arn(topic_name)to get or createtopic_arnonce.verified that
create_topichappened only once onBarkMQ::Publisher.publishand it doesn't require to make any enhancement for cardSPIKE-40450Testing Scope:
-Check all the services that are using this gem to make sure all services are working as it used to.
-Open AWS Account & remove previously created SNS topics
-run rspec
(NOTE:
async_publisher_spec.rbis failing related to timeout. I haven't changed anything in this area but the test case is still failing locally. Maybe, It requires to run on live CI env. Other specs are passing without any issue. I double checked celluloid usage and it looks good).-verify new topics which were created