Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do FCS 41 update in hopes of getting somewhere with cracking #2

Merged
merged 7 commits into from
Nov 6, 2021

Conversation

baronfel
Copy link
Owner

@baronfel baronfel commented Nov 6, 2021

No description provided.

@baronfel baronfel force-pushed the fcs41-bump-proj-info branch from b2e3805 to 3e71b75 Compare November 6, 2021 16:49
@baronfel
Copy link
Owner Author

baronfel commented Nov 6, 2021

This works for local testing! Automated tests are pretty borked though, and I'm pretty sure it's because we don't run them isolated the same way a user would if they were using the product via ionide.

The plan is to:

  • merge this MR into the proj-info MR it's based off of
  • manually test that MR against windows/osx/ubuntu using the existing automated tests as the sample setup
  • if manual tests pass, merge the MR and do an ionide release
  • the next unit of effort then goes to refactoring the tests to be isolated in the same way a user would access FSAC, instead of in-memory.

@baronfel baronfel merged commit 91c79d7 into update-proj-info Nov 6, 2021
@baronfel baronfel deleted the fcs41-bump-proj-info branch November 6, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant