Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the input method of bitrate. Bug fix #439

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

ZXfkSIE
Copy link
Contributor

@ZXfkSIE ZXfkSIE commented Jun 28, 2021

Modification

  • Change the input method (as well as the related code) of bit rate. Now bit rate can be input manually, instead of limited choices.

Bug Fixes

  • BUG : system tray icon will be permanently hided after clicking that icon for showing the hided dialog.
    • CAUSE: m_hideIcon->hide() is called after clicking the icon.
    • SOLUTION: Just don't hide it.
  • BUG: the destructor of Dialog is not called while exiting the application.
    • CAUSE: Objects allocated on the heap will not be deleted automatically.
    • SOLUTION: delete it manually after exec() returns.
  • BUG: CMake scripts failed to link FFmpeg with MSVC.

@ZXfkSIE ZXfkSIE force-pushed the dev branch 2 times, most recently from 049ba21 to 110f99a Compare June 29, 2021 02:16
dijo7
dijo7 previously approved these changes Jul 1, 2021
QtScrcpy/dialog.cpp Outdated Show resolved Hide resolved
QtScrcpy/dialog.ui Outdated Show resolved Hide resolved
QtScrcpy/res/i18n/zh_CN.ts Outdated Show resolved Hide resolved
@barry-ran barry-ran merged commit 3050827 into barry-ran:dev Jul 7, 2021
re2zero pushed a commit to re2zero/QtScrcpy that referenced this pull request Aug 17, 2022
Modify the input method of bitrate. Bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants