Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable back to original size after exit fullscreen. #666

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

re2zero
Copy link
Contributor

@re2zero re2zero commented Aug 18, 2022

After exit fullscreen, it still show as fullscreen with title, this make user feel unwell. Record the normal size and then recover will be beter.

Log: support recover size.

After exit fullscreen, it still show as fullscreen with title, this make user feel unwell. Record the normal size and then recover will be beter.

Log: support recover size.
@barry-ran
Copy link
Owner

I didn't reproduce this problem. Can you record a video to describe it

@re2zero
Copy link
Contributor Author

re2zero commented Sep 13, 2022

@barry-ran Hello Barry,
Welcome back and thanks your reply. I mean, if a user wants the phone's share exit full screen, it resizes back to the
previous window size will be better, then user can view other window, right? Currently, it still show full screen with title bar.
I have uploaded this screen record video, please check.

fullscreen-2-normal.mp4

BTW, there is another my patch which about QtScrcpyCore, which fixed a build issue. Would you take a look? Thanks a lot.

@re2zero
Copy link
Contributor Author

re2zero commented Sep 13, 2022

Some screenshots:
image

image

@barry-ran barry-ran merged commit ffaf41d into barry-ran:dev Sep 14, 2022
barry-ran added a commit that referenced this pull request May 11, 2024
feat: enable back to original size after exit fullscreen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants