Add angle brackets around links that contain spaces to increase compatibility #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the info. I had no idea that was a problem. Changes look good. I should be able to test them this weekend just to make sure. |
|
That's awesome to hear! Let me know if there's anything I can do to help :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Love the project, only catch was for my Reddit app I was getting a few users complaining my Markdown renderer (which uses GitHub's renderer) doesn't render some of your links properly, e.g.: https://www.reddit.com/r/apolloapp/comments/s5tsk9/link_markdown_broken_i_think_it_has_to_do_with/
The "issue" (if you'd call it that) is that when you create the URL to PM you with, you include some JSON there that has spaces in it, which breaks GitHub's Markdown renderer. The Reddit website handles this properly somehow, but I thought I'd make a quick PR that wraps the URLs in
<angled brackets>which per Commonmark (which Reddit also supports) allows you to add spaces to URLs for increased compatibility. I updated the tests to reflect this.tl;dr: shouldn't break anything but should increase compatibility.