Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check namespace + class to see if it exists #6 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barryvdh
Copy link
Owner

Re-do #6 by @Stevemoretz

@barryvdh
Copy link
Owner Author

Are these changes correct? If so can you update the tests?

@Jefemy
Copy link

Jefemy commented Feb 22, 2023

I pushed a concept of what proper tests could be here but i'm not sure I can get much further with it. I fixed some cases by actually creating the classes it is looking for, but I'm not entirely sure what the Alias values do but those aren't failing so maybe those are fine? The remaining tests are failing as provideTypesToExpandWithoutNamespace and provideTypesToExpandWithPropertyOrMethod expect a leading \ that the code no longer provides, not really sure if thats a bug or where to go with that.

I did find one issue with the change, as in one of the tests it has a method of ::setLink() attached which was going directly through to the shouldBeAbsolute function causing it to not properly detect the class there. A simple change to $this->shouldBeAbsolute(explode('::', $with_name_space)[0]) on line 217 is enough to fix that though.

@barryvdh
Copy link
Owner Author

I'm not sure if this is still required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants