Support nested generics and closures type hint #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where an incorrect parsing result was returned when the type declared in
@param
was a nested generic type or closure.A simple solution was already in place for generic types, but it did not support cases where multiple whitespaces were included due to nesting. Closures also use whitespace when defined accurately, but this was not supported either.
I fixed this issue by implementing a simple parser.
Issues this pull request resolves
Testing overview
I not only added many test cases, but also tested Laravel IDE Helper with this patch applied. The results changed as follows:
Resolving barrydh/laravel-ide-helper#1505
Failed the xfail-equivalent test. The issue appears to have been fixed.
Fixed multiple issues with Laravel IDE Helper
This is a test that recently failed due to a change in the Laravel Framework. The patch changed the reason for the failure.
For reference, without this patch, the failure reason will be as follows:
Before the patch, the output was obviously broken. As already shown, this will now be accurate.