Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is not necessary to deprecate the
setOptions
method, the problem was that it removed all the default settings, but withapp()->make('dompdf.options')
we get a copy ofconfig/dompdf.php
before adding the options, the functionality is maintained and it is shorter to use than the original methodhttps://github.com/dompdf/dompdf/blob/56a660ce045ee27c84154c60b612c936ddb86398/src/Dompdf.php#L1327
Also with an empty array we could reset options to default
config/dompdf.php
config, example:$pdf->setOptions([])
Closes #793 (comment)
UPDATE: Test added