Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json: remove --prefer-lowest #1217

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented May 3, 2021

Summary

IMHO it's impractical to expect this package to have to work with the
"first release of Laravel for any major release" even when there are
already sever more releases: no one is/should stick to that version.

This is a re-submit of #1076

See also for recent breakaes

Note: PHP8 already didn't include it

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

IMHO it's impractical to expect this package to have to work with the
"first release of Laravel for any major release" even when there are
already sever more releases: no one is/should stick to that version.

This is a re-submit of barryvdh#1076

See also:
- barryvdh#1216 (comment)
- barryvdh#1185 (comment)
@mfn mfn self-assigned this May 3, 2021
@mfn mfn requested a review from barryvdh May 3, 2021 06:33
@mfn
Copy link
Collaborator Author

mfn commented May 6, 2021

@barryvdh can you take a look at this issue? All PRs currently fail due to prefer-lowest not working and, TBH, I don't have much interest in chasing down the actual minimum version and would rather get the ball rolling forward (though happy if someone else has time to figure this out)

@Messhias
Copy link

I would like to do a review on this, but it's seems blocked to me.

@barryvdh barryvdh merged commit df67074 into barryvdh:master Jun 20, 2021
@mfn mfn deleted the mfn-composer-no-lowest branch June 20, 2021 19:23
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
IMHO it's impractical to expect this package to have to work with the
"first release of Laravel for any major release" even when there are
already sever more releases: no one is/should stick to that version.

This is a re-submit of barryvdh#1076

See also:
- barryvdh#1216 (comment)
- barryvdh#1185 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants