Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecations #1618

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

JeppeKnockaert
Copy link
Contributor

@JeppeKnockaert JeppeKnockaert commented Nov 27, 2024

Summary

This PR removes implicitly nullable parameters because these result in deprecation warnings for PHP 8.4.

https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter

Type of change

  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@JeppeKnockaert JeppeKnockaert changed the title Replace implicitly nullable parameters for PHP 8.4 Fix PHP 8.4 deprecations Nov 27, 2024
@dcranford-em
Copy link

This would be great to get merged in. My logs are filling up with deprecation warnings

@barryvdh barryvdh merged commit edb5675 into barryvdh:master Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants