Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testsuite for Generator, simplify service provider and mock #1635

Merged
merged 7 commits into from
Dec 28, 2024

Conversation

barryvdh
Copy link
Owner

Summary

I think the models were not typehinted because of Lumen etc. Now that we've bumped versions, we can skip Lumen.

Also simplified the serviceprovider and the mock a bit, to allow for testing the Generator.

The Filesystem mock only mock the Put method now, rest is not mocked (partial mock).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh barryvdh requested a review from mfn December 28, 2024 18:26
@barryvdh
Copy link
Owner Author

Ah yes, of course the actual file is different based on the PHP version, which makes it a bit difficult I guess 🤔

@barryvdh barryvdh merged commit 14fdb57 into master Dec 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant