Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test in ci #3

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Add test in ci #3

merged 9 commits into from
Jun 25, 2024

Conversation

olleolleolle
Copy link

@olleolleolle olleolleolle commented Jun 20, 2024

This PR adds CI configuration to the repository.

Turned out that there was one commit which added test cases and data that failed tests.

All the patterns and country descriptions added in this one fail:
793dd95

  • In order to make this "pass", I extracted tests that were failing into their own describe block, and marked it pending.
  • Use expect in all tests to be able to upgrade warning-free to RSpec 3.
  • Upgrade to RSpec 3.
  • Add the script/test convenience script.

Copy link

@ximes ximes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
❓ What's up with the single/double quotes? Was it intended (we have/had a different setup here) or it was just auto-corrected?

@olleolleolle
Copy link
Author

Very nice! ❓ What's up with the single/double quotes? Was it intended (we have/had a different setup here) or it was just auto-corrected?

autocorrect, sorry about that

@olleolleolle olleolleolle merged commit 6a18632 into master Jun 25, 2024
5 checks passed
@olleolleolle olleolleolle deleted the add-test-in-ci branch June 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants