Skip to content

Conversation

@lnlion
Copy link

@lnlion lnlion commented Jun 9, 2025

No description provided.

@bart6114
Copy link
Owner

Thanks a lot for the contribution 🙏

That said, this approach solves the issue specifically for Chinese output on Windows, but it’s a bit too platform- and encoding-specific to land in the main codebase as-is.

I’ve proposed a more generic solution in PR #273, which allows you to specify output encoding per job via YAML. Also added some minor verification tests and added it to the docs.

Would be highly appreciated if you can give #273 a try with something like below (I don't have access to a Windows machine so it's a bit tedious to mimick).

jobs:
  legacy_chinese_job:
    command: legacy-chinese.exe
    encoding: gb18030

@bart6114
Copy link
Owner

bart6114 commented Jul 6, 2025

Ping @lnlion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants