Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: improves to optimize DX #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iosamuel
Copy link

@iosamuel iosamuel commented Jun 8, 2022

This PR is to improve DX overall after several issues I have found would be greatly appreciated by any developer using this library.

For instance:

  • Arrow icons slots: this will allow developers to simply change the icon of the arrows and simply style the buttons at their preference without having to implement the whole logic of the buttons
  • Pass more props to the arrows slot: I found myself trying to implement the whole logic on the arrows and was almost impossible to implement it completely because of missing state variables needed as well as the i18n default text
  • Possibility to hide scrollbar on demand: this library is extremely powerful because of its native css usage of the scroll, giving away completely the scrollbar is not something really useful, sometimes you may want to keep the scrollbar for Desktop users so they can use the native scroll to scroll faster through items (real use case on my company)

Sorry about some changes made in the style of the code, I tried to be as tight as possible to the code style, that's why I implemented the .prettierrc configuration file, this will make it easier to contribute to the code later as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant