Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-operation metric collector facility #1

Closed
wants to merge 3 commits into from

Conversation

bartelink
Copy link
Owner

@bartelink bartelink commented Mar 21, 2022

Adds the facility to supply a metrics collector at the individual operation level
This enables one to deterministically attribute metrics to individual calls on a given TableContext

@bartelink
Copy link
Owner Author

bartelink commented Mar 21, 2022

@samritchie re fsprojects#39 (comment), I did this as a spike to validate the effort/ripple effects with a view to using it in jet/equinox#321
Can post this as a PR on the main repo, but am happy for you to do it your own way in your own time too
Also can perhaps push some diffs and/or preparatory work (e.g. reformatting all member declaration lines with a max line length if 80/120 chars?) into fsprojects#40

@samritchie
Copy link

@bartelink I'll pull this branch down today & have a look at it, I'd like to put some tests around metricsCollector as well so I'll dig into what we get back from dynamodb-local and make sure it’s going to work.

@bartelink
Copy link
Owner Author

@bartelink bartelink closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants