Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the demo site #2142

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Cache the demo site #2142

merged 1 commit into from
Oct 18, 2024

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Oct 17, 2024 •
edited
Loading

This fixes #2139

@bartfeenstra bartfeenstra marked this pull request as ready for review October 18, 2024 13:15
@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Oct 18, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Oct 18, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.29%. Comparing base (f0a83c9) to head (75ed4b3).
Report is 1 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/project/extension/demo/serve.py 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            0.4.x    #2142      +/-   ##
==========================================
- Coverage   98.30%   98.29%   -0.01%     
==========================================
  Files         358      358              
  Lines       22722    22724       +2     
  Branches     1056     1058       +2     
==========================================
  Hits        22336    22336              
- Misses        244      246       +2     
  Partials      142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 09ab7a7 into 0.4.x Oct 18, 2024
6 of 8 checks passed
@bartfeenstra bartfeenstra deleted the cache-demo-site branch October 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Cache demo site builds
1 participant
@bartfeenstra