Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when loading Gramps files that do not exist on disk #2202

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #2198

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code labels Nov 11, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Nov 11, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review November 11, 2024 21:55
@bartfeenstra bartfeenstra merged commit cd278a3 into 0.4.x Nov 11, 2024
6 checks passed
@bartfeenstra bartfeenstra deleted the gramps-error-file-not-found branch November 11, 2024 22:09
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.20%. Comparing base (134d9e2) to head (4d6d28d).
Report is 1 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/gramps/loader.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #2202      +/-   ##
==========================================
- Coverage   98.21%   98.20%   -0.01%     
==========================================
  Files         364      364              
  Lines       23138    23164      +26     
  Branches     1067     1068       +1     
==========================================
+ Hits        22724    22748      +24     
- Misses        267      268       +1     
- Partials      147      148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if GrampsLoader encounters file entities with paths to non-existent files
1 participant