Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Using the Mikro-ORM Global Identity Map could cause unrealized issues #100

Closed
1 task done
ShoGinn opened this issue Dec 16, 2022 · 0 comments · Fixed by #101
Closed
1 task done

[Bug] Using the Mikro-ORM Global Identity Map could cause unrealized issues #100

ShoGinn opened this issue Dec 16, 2022 · 0 comments · Fixed by #101
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ShoGinn
Copy link

ShoGinn commented Dec 16, 2022

What happened?

The best practice, according to Mikro-Orm, Is not to disable the validation checks for the global identity map.
https://mikro-orm.io/docs/identity-map#global-identity-map

allowGlobalContext: true,

Fixing the code with appropriate middleware or constantly forking the entity manager is the solution.

I am unsure of how to implement this fix.

Reproduction

Disable

allowGlobalContext: true,

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ShoGinn ShoGinn added the bug Something isn't working label Dec 16, 2022
@barthofu barthofu added this to the v2.1 milestone Dec 17, 2022
@barthofu barthofu linked a pull request Dec 22, 2022 that will close this issue
@barthofu barthofu closed this as completed Jan 2, 2023
@barthofu barthofu reopened this Jan 2, 2023
@barthofu barthofu added the next The issue has been fixed / implemented and it will be released in the next version label Jan 2, 2023
@barthofu barthofu mentioned this issue Feb 7, 2023
@barthofu barthofu removed the next The issue has been fixed / implemented and it will be released in the next version label Mar 8, 2023
@barthofu barthofu closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants