Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Split custom events and discord events #103

Closed
barthofu opened this issue Jan 2, 2023 · 0 comments
Closed

[Feature] Split custom events and discord events #103

barthofu opened this issue Jan 2, 2023 · 0 comments
Assignees
@barthofu
Labels
enhancement New feature or request
Milestone
v2.1

Comments

@barthofu
Copy link
Owner

barthofu commented Jan 2, 2023

Feature

Atm, we are using the discordx event store to register custom events. It is in fact a really bad thing as the custom events will also pass through the handling pipeline, including the global middlewares which can be blocking in many cases.
@barthofu barthofu added the enhancement New feature or request label Jan 2, 2023
@barthofu barthofu added this to the v2.1 milestone Jan 2, 2023
@barthofu barthofu self-assigned this Jan 2, 2023
barthofu added a commit that referenced this issue Jan 2, 2023
@barthofu
feat(#103): custom event and event manager
9dffb7b
barthofu added a commit that referenced this issue Jan 2, 2023
@barthofu
feat(#103): custom event and event manager
8c77a18
@barthofu barthofu added the next The issue has been fixed / implemented and it will be released in the next version label Jan 2, 2023
barthofu added a commit that referenced this issue Jan 23, 2023
@barthofu
feat(#103): custom event and event manager
bcc74eb
@barthofu barthofu removed the next The issue has been fixed / implemented and it will be released in the next version label Jan 23, 2023
@barthofu barthofu mentioned this issue Feb 7, 2023
Merged
barthofu added a commit that referenced this issue Mar 7, 2023
@barthofu
feat(#103): custom event and event manager
aeb218e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthofu barthofu

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1
Development

When branches are created from issues, their pull requests are automatically linked.

103-feature-split-custom-events-and-discord-events barthofu/tscord
1 participant
@barthofu