-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from cjs
to esm
#154
Draft
barthofu
wants to merge
20
commits into
main
Choose a base branch
from
feat/esm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+12,189
−8,057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4f92837.
by bumping versions again
and convert the old WS event emitters to API endpoints for the dashboard
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
for security concerns
through `envalid`
barthofu
force-pushed
the
version/2.3
branch
from
February 21, 2024 00:13
5aa69e8
to
f7464eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is an attempt to
finalymigrate from CJS to ESM.Problem(s)
The most important problem is that ts-node (for dev) doesn't support
tsconfig.paths
aliases resolution in ESM. I've managed to quite fix that using a custom loader (./loader.js
).We also want to keep the commands and events HMR.
What I've done so far
tsconfig.target
andtsconfig.module
toesnext
tsnode
config block in the tsconfig json filecase
dep which was CJS-only withchange-case
.resolveDependencies
4.1 because of the error
Cannot access X before initialization
Solutions
Notes