Hack around Hunspell crashes on Supplementary Unicode plane codepoints #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The absolutely ancient Hunspell version that was bundled with the SpellChecker Node bindings did not have a full Unicode support at the time and it crashes when faced with non-BMP codepoints. So we just replace all of those with spaces here.
By replacing the non-BMP codepoints with two spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The absolutely ancient Hunspell version that was bundled with the SpellChecker Node bindings did not have a fully functional support for full Unicode at the time, and it crashes when faced with non-BMP (
U+10000...) codepoints (those include most emoji, among many other things). So we just replace all of those with spaces here.This fixes #284, fixes #450 and fixes #511.
A more robust solution would entail updating Hunspell in SpellChecker.