Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTransactionHash to use un-decorated function for better tree shaking #116

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

kyscott18
Copy link
Contributor

Not using the functions extended from client allows for bundlers to tree shake more effectively

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
op-viem-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 2:54pm

@wilsoncusack
Copy link
Collaborator

@kyscott18 good call, thanks for this!

wilsoncusack
wilsoncusack previously approved these changes Sep 20, 2023
@wilsoncusack
Copy link
Collaborator

Lint error, also if you don't mind, could you run pnpm changeset and make it a patch change

@kyscott18
Copy link
Contributor Author

Fixed the lint and added the changeset

@kyscott18 kyscott18 temporarily deployed to verify September 20, 2023 14:55 — with GitHub Actions Inactive
@wilsoncusack wilsoncusack merged commit 745a65a into base-org:main Sep 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants