Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CoW Swap to Base Ecosystem section #1434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add CoW Swap to Base Ecosystem section #1434

wants to merge 3 commits into from

Conversation

cmagan
Copy link

@cmagan cmagan commented Dec 20, 2024

  • Added all necessary details to ecosystem.json
  • Added CoW Swap logo to the relevant directory

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:39am

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024

@cmagan is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 20, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base ecosystem review This is ecosystem related label Dec 20, 2024
wbnns
wbnns approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cmagan Thanks for building on Base 🔵

@wbnns
Copy link
Member

wbnns commented Dec 21, 2024

@cmagan Looks like this needs to be rebased and then we can bring this in 👍

@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2024-12-21 00:32:53 UTC
User failed mfa authentication, see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmagan @cb-heimdall @wbnns