-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECOIN Wallet to Base Ecossystem #1442
Conversation
Add ECOIN Wallet to Base ecosystem
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ecoin-finance is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
Can someone check and approve it? |
Hello, thank you for opening this PR and adding support for Base. Unfortunately, we are unable to add ECOIN at this time due to it being primarily focused around the ECOIN token, as described in the fourth bullet under the "Tips for a successful submission" section of the README, and also in the "What to avoid" section in the Base Editorial Style Guide. Once this language is changed and updated, please feel free to open a new pull request and we will re-review. 🙏 |
Hello, @wbnns @cb-heimdall I’d like to clarify a misunderstanding: the ECOIN Wallet is not a token but a product developed by ECOIN Finance, much like how the ECOIN token is a separate product within our ecosystem. The ECOIN Wallet is a versatile cryptocurrency wallet that supports a wide range of tokens, providing utility far beyond just our native token. By your logic, wallets such as Trust Wallet, which also have associated tokens like TWT, would face similar restrictions, yet they are widely recognized as standalone products serving diverse audiences. Additionally, my team has spent several weekends working tirelessly to implemen base. We’ve also invested significant effort in making announcements with Base to benefit the broader community. I kindly ask you to reevaluate the classification of ECOIN Wallet based on its functionality as a crypto wallet rather than conflating it with its association with the ECOIN token. Thank you for your consideration, and I look forward to your feedback. |
What changed? Why?
Notes to reviewers
How has it been tested?
To test:
Screenshots
Below are screenshots of the ECOIN Wallet app showcasing its features with Base integration: