Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECOIN Wallet to Base Ecossystem #1442

Closed
wants to merge 2 commits into from

Conversation

ecoin-finance
Copy link

What changed? Why?

  • Initial submission of the ECOIN Wallet app to the Base ecosystem.

Notes to reviewers

  • The ECOIN Wallet is a cryptocurrency wallet available exclusively for Android devices.
  • The app is public and receives regular updates to enhance functionality.
  • The latest update includes full support for Base, with features like Deposit, Withdraw, Swap, and Cross-Chain functionality powered by ZetaChain.

How has it been tested?

To test:

  1. Create or connect a wallet within the app.
  2. Select Multichain, or for the best results, choose Base as the network.
  3. Test the following supported features:
    • Deposit and Withdraw on Base.
    • Swap functionality built directly into the wallet.
    • Cross-chain swaps powered by ZetaChain.
    • Seamless DApp integration.

Screenshots

Below are screenshots of the ECOIN Wallet app showcasing its features with Base integration:

base (1) base (2) base (3)

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:27pm

Copy link

vercel bot commented Dec 20, 2024

@ecoin-finance is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 20, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@ecoin-finance
Copy link
Author

Can someone check and approve it?

@wbnns @cb-heimdall

@wbnns
Copy link
Member

wbnns commented Dec 28, 2024

@ecoin-finance

Hello, thank you for opening this PR and adding support for Base. Unfortunately, we are unable to add ECOIN at this time due to it being primarily focused around the ECOIN token, as described in the fourth bullet under the "Tips for a successful submission" section of the README, and also in the "What to avoid" section in the Base Editorial Style Guide.

Once this language is changed and updated, please feel free to open a new pull request and we will re-review. 🙏

@wbnns wbnns closed this Dec 28, 2024
@ecoin-finance
Copy link
Author

Hello, @wbnns @cb-heimdall

I’d like to clarify a misunderstanding: the ECOIN Wallet is not a token but a product developed by ECOIN Finance, much like how the ECOIN token is a separate product within our ecosystem.

The ECOIN Wallet is a versatile cryptocurrency wallet that supports a wide range of tokens, providing utility far beyond just our native token. By your logic, wallets such as Trust Wallet, which also have associated tokens like TWT, would face similar restrictions, yet they are widely recognized as standalone products serving diverse audiences.

Additionally, my team has spent several weekends working tirelessly to implemen base. We’ve also invested significant effort in making announcements with Base to benefit the broader community.

I kindly ask you to reevaluate the classification of ECOIN Wallet based on its functionality as a crypto wallet rather than conflating it with its association with the ECOIN token.

Thank you for your consideration, and I look forward to your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants