-
Notifications
You must be signed in to change notification settings - Fork 18
feat: e2e tests + framework #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| gas_limit: u64, | ||
| gas_price: u128, | ||
| ) -> Result<Bytes> { | ||
| let tx = TxLegacy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, any reason for TxLegacy over TxEip1559?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question, primarily because it had fewer arguments and was easier to work with initially. I'm about to push a change to fix the broken tests, so I can swap over to TxEip1559 (or if we want multiple types of transaction builders, happy to keep the TxLegacy and add TxEip1559 and subsequent tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good! i think we can leave txlegacy for now and then if we actually need txeip1559 later we can just swap it out in a follow up
Uh oh!
There was an error while loading. Please reload this page.