refactor: add bundle helpers #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
commented
Oct 31, 2025
wlawt
commented
Oct 31, 2025
niran
reviewed
Oct 31, 2025
wlawt
commented
Oct 31, 2025
danyalprout
reviewed
Nov 3, 2025
wlawt
commented
Nov 5, 2025
wlawt
commented
Nov 5, 2025
danyalprout
reviewed
Nov 5, 2025
niran
reviewed
Nov 5, 2025
Comment on lines
+93
to
+98
| let uuid = bundle | ||
| .replacement_uuid | ||
| .clone() | ||
| .unwrap_or_else(|| Uuid::new_v4().to_string()); | ||
|
|
||
| let uuid = Uuid::parse_str(uuid.as_str()).map_err(|_| format!("Invalid UUID: {uuid}"))?; |
There was a problem hiding this comment.
Oh, this isn't what I thought was going to happen. I thought replacement_uuid was going to change from an Option<String> to a Option<Uuid>. Then AcceptedBundle::new() would populate its uuid field with replacement_uuid.unwrap_or_else(|| Uuid::new_v4()) (without the to_string).
If ParsedBundle has its own uuid field, the same bundle is going to get multiple uuids assigned over its lifetime.
niran
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduce
BundleTransactionsandBundleParamsto be shared acrossBundleandBundleWithMetadatato easily access utility functions.Also implement
FromandTryFromacross these structs to interchange easily