Skip to content

Conversation

@and-cb
Copy link
Collaborator

@and-cb and-cb commented Jun 24, 2025

Also add a way to create a new database, without failing if it already exists.

Examples

// Open or create
Database::options().create(true).open(".../path");

// Create or fail if the db already exists
Database::options().create_new(true).open(".../path");

// Create or wipe if the db already exists
Database::options().create(true).wipe(true).open(".../path");

// Specify a path for the metadata file
Database::options().meta_path(".../meta-path").open(".../db-path");

@and-cb and-cb requested review from BrianBland and jjtny1 June 24, 2025 20:54
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 24, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

BrianBland
BrianBland previously approved these changes Jun 26, 2025
@and-cb and-cb force-pushed the andrea/db-builder branch from 7c85d4a to e8af907 Compare June 30, 2025 21:12
@cb-heimdall cb-heimdall dismissed BrianBland’s stale review June 30, 2025 21:12

Approved review 2962786088 from BrianBland is now dismissed due to new commit. Re-request for approval.

@and-cb and-cb force-pushed the andrea/db-builder branch from e8af907 to 6d2b7f9 Compare June 30, 2025 21:27
@BrianBland BrianBland changed the title Add DatabaseOptions to let callers specify the metadata file path feat: Add DatabaseOptions to let callers specify the metadata file path Jul 1, 2025
Also add a way to create a new database, without failing if it already
exists.
@and-cb and-cb force-pushed the andrea/db-builder branch from 6d2b7f9 to 13b3247 Compare July 2, 2025 22:50
@and-cb and-cb merged commit e207624 into main Jul 2, 2025
17 checks passed
@and-cb and-cb deleted the andrea/db-builder branch July 2, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants