Skip to content

chore: fixes for onchainkit demo #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

xtbase
Copy link
Contributor

@xtbase xtbase commented Jul 21, 2025

What changed? Why?

  • Adds in a very hacky solution to fix the styling issue for onchainkit demo
  • The underlying cause is likely due to the specific onchainkit version we are using having issues with findComponent. However we can't upgrade onchainkit as of this version due to not wanting to break basenames
  • Once onchainkit v1 is stable let's migrate over and remove this hacky solution

Notes to reviewers

How has it been tested?

Manually but the issue is mainly on prod

Screenshot 2025-07-20 at 10 06 38 PM

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@xtbase xtbase requested a review from dgca July 21, 2025 05:08
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 21, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:13am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants