Improve protection mechanisms, design and documentation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaced the old system to validate commands based on regular expressions with a system based on proper Ruby parsing. The new system uses (https://github.com/whitequark/parser) internally.
`Supervisor` was doing too many things. This extracts `Shield` and `CommandExecutor` as first level entities distributing part of the original responsibilities.
jorgemanrubia
force-pushed
the
protect-db-drivers
branch
2 times, most recently
from
008715d to
5f0eead
Compare
jorgemanrubia
force-pushed
the
protect-db-drivers
branch
from
582e66d to
7e58724
Compare
This was referenced Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
parsergem.Supervisorhad ended up having way too much responsibility. This distributes those responsibilities across new entities:CommandExecutor,CommandValidatorandShield. It also reviews domain terms aiming for more clarity and consistency (e.g: don't use "access" to reference what we are calling "protected modes" in other places).The new system is used to prevent using database drivers directly (fixes #22).