Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex pattern documentation for denied paths in README #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mybuddyandrew
Copy link

@mybuddyandrew mybuddyandrew commented May 9, 2024

Improve Documentation for Regex Patterns in 'Mission Control - Web'

This pull request updates the documentation related to regex patterns used for blocking specific routes in 'Mission Control - Web'. The enhancements include:

  • Detailed Regex Examples: The regex patterns are now more detailed, covering use cases such as blocking entire namespaces (e.g., /admin/.*), specific controller actions (e.g., /users/edit), and API routes under a specific version (e.g., /api/v1/.*). These examples provide clear guidance on how to effectively configure the middleware to deny access to unwanted paths.

#41 (comment)

@lewispb
Copy link
Member

lewispb commented May 13, 2024

Thanks for the PR @mybuddyandrew.

Three examples feels about right, but perhaps we can capture some more variety? I'm thinking examples where there's an ID in the middle of a path, or perhaps all paths ending in "/new".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants