-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raspberry pi compatibility #227
base: master
Are you sure you want to change the base?
Conversation
4dec8e0
to
abcf738
Compare
Hey @IbrahimTanyalcin can you rebase off the latest |
abcf738
to
dd3c4a8
Compare
@rmacklin Thanks for letting me know, I've rebased, there were no merge conflicts. |
dd3c4a8
to
b22531c
Compare
b22531c
to
1618bb3
Compare
if [[ -z $UTILS_SOURCED ]]; then | ||
source ~/.local/share/omakub/utils.sh | ||
fi | ||
ARCH=$(get_arch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARCH=$(get_arch) | |
ARCH=$(get_arch "mise") |
And an entry in utils.sh as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjeldahl get_arch
at here: https://github.com/IbrahimTanyalcin/omakub/blob/raspi5-compat/utils.sh#L80-L94 will default to lscpu
's output if no entries are found here: https://github.com/IbrahimTanyalcin/omakub/blob/raspi5-compat/utils.sh#L37-L54
I think you want it to be more explicit, in that case I can add these identity entries to the assoc array here: https://github.com/IbrahimTanyalcin/omakub/blob/raspi5-compat/utils.sh#L38 like:
["mise.aarch64"]="aarch64"
["mise.x86_64"]="x86_64"
I only added values to that array for the programs that deviate from lscpu's standard arch notation. But if you believe being explicit is better I will do that. What do you think?
…wnload deb file directly and install via apt. Install neovim through snapd for aarch64.
… snap neovim to usr/local/bin/nvim
1618bb3
to
f49d555
Compare
I wanted to try Omakub in my raspberry pi5, however ran into premature termination of the script in multiple places. These modifications should not change anything for amd64 but allow installation of most of the apps in raspberry. In the end I was able to have all the good bits working except these:
So I finally was able to try Omakub like in the introductin video, and it is really cool! Window tiles and shortcuts are great!
Here are the changes:
utils.sh
to deal with vendor imcompatibilities when naming architechtures amd64 vs x86_64, aarch64 vs arm64 etc.dpkg --print-architechture
is not enough to deal with all the incosistencies so there is an extendablearch_config
variable for future apps.XDG_CURRENT_DESKTOP
is not onlyGNOME
butubuntu:GNOME
, so made some changes to deal with possible variations without breaking current behavioramd64
andx86_64
and replaced them with output ofget_arch
, the output defaults to lscpu's values but can be customized based on app by adding keys toarch_config
array inutils.sh
set -e
(I undestand the intention of putting set -e but when something goes wrong you are left with a broken install anyway). So if one of the apps fail, the parent script will continue unless there is something else in the parent script that triggersset -e
, that behavior is left unchanged. The failed apps are reported in a formated way inside the root folder calledomakub_report.log
.utils.sh
calledhandle_omakub_source_error
andhandle_omakub_source_success
which are used byprint_omakub_report | tee ~/.local/share/omakub/omakub_report.log
, this will list all the successful and failed ones. Currently in rasberry pi 5, I only had 5 failed which some of them do not have arm64 releases.These changes should not introduce any breaking changes or modifications for
amd64
but will allow people to install and give Omakub a try in their arm64 devices and track what failed or not down the line.*** Please test this in your
amd64
machines and verify I did not accidentally introduced breaking changes. ***