Fix shell completion for 'ls' alias by setting '--icons=auto' #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated 'ls' alias to use '--icons=auto' to resolve issue with shell completions, which previously prompted options instead of completing filesystem entries.
adoreblvnk
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
lsalias to use--icons=auto, fixing an issue with shell completion in some environments.I'm using omakub with zsh, which I realize is outside the primary design scope. However, I noticed that the
lsalias wasn't completing filesystem entries as expected. Instead, when tabbing after an emptylscommand, it prompted options:always,auto,automatic, andnever. These are the choices for the--iconsdisplay option ineza, as listed in its man page.By setting
--icons=auto, shell completions work as intended, displaying filesystem entries. While this issue may be specific to my environment, this change should be a no-op in other cases and ensures compatibility where needed.