Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Docker's apt repo for fresher releases #83

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

jeremy
Copy link
Member

@jeremy jeremy commented Jun 11, 2024

Ubuntu 24.04 packages Docker 24. Official repo packages Docker 26. Track the latest rather than the distro.

@jeremy jeremy requested a review from dhh June 11, 2024 04:15
@jeremy jeremy force-pushed the fresh-docker branch 2 times, most recently from 767777c to a2eb04c Compare June 11, 2024 04:22
@jeremy jeremy requested a review from dhh June 11, 2024 20:52
@dhh dhh merged commit d29e213 into master Jun 11, 2024
@dhh dhh deleted the fresh-docker branch June 11, 2024 21:17
@dhh dhh restored the fresh-docker branch July 14, 2024 08:43
@dhh
Copy link
Member

dhh commented Jul 14, 2024

We need to have another go at this. I couldn't get it working out of the box with lazydocker connecting correctly on a fresh installation. So reverted it at the last minute before release.

@thaJeztah
Copy link

Hm.. interesting; do you have more information on what happened? The only thing coming to mind is possibly differences in the systemd unit, with more current versions being configured to wait for other services / dependencies to be up

Comment on lines 17 to +21
DOCKER_COMPOSE_VERSION="2.27.0"
DOCKER_CONFIG=${DOCKER_CONFIG:-$HOME/.docker}
mkdir -p $DOCKER_CONFIG/cli-plugins
curl -sSL https://github.com/docker/compose/releases/download/v$DOCKER_COMPOSE_VERSION/docker-compose-linux-x86_64 -o $DOCKER_CONFIG/cli-plugins/docker-compose
chmod +x $DOCKER_CONFIG/cli-plugins/docker-compose
chmod +x $DOCKER_CONFIG/cli-plugins/docker-compose

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just realised that the script is installing compose twice (once from the deb package, and once from the static binaries from GitHub), although that shouldn't be problematic (other than possibly pinning / overriding with an older version).

@haberbyte
Copy link

I wonder what the problem with docker or lazydocker even is? I just tried it on a fresh Ubuntu installation in a VM and everything works great when installing docker like this 🤷‍♂️

@jeremy
Copy link
Member Author

jeremy commented Jul 31, 2024

I couldn't get it to fail either. Just works on fresh install, reinstall, and after switching to Ubuntu packages and back. Will reopen a fresh PR: #238

@thaJeztah
Copy link

Also had a look at lazydocker to see if anything stood out immediately; it was still using an old version of the docker dependencies, so updated them to more current versions jesseduffield/lazydocker#561 (comment) (don't think those changes are released yet though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants