Fix XSS vulnerability on paste #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
force-pushed
the
paste-vuln
branch
from
8f7608e
to
c8dbd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a security vulnerability related to pasting malicious code in a Trix editor. In PR #1149, we added sanitation for Trix attachments with a
text/htmlcontent type. However, Trix only checks the content type on the paste event'sdataTransferobject. As long as thedataTransferhas a content type oftext/html, Trix parses its contents and creates anAttachmentwith them, even if the attachment itself doesn't have atext/htmlcontent type. Trix then uses the attachment content to set the attachment element'sinnerHTML.This PR introduces a new
HTMLSanitizer.setHTML(element, html)method to safely set the innerHTML of an element and then replaces all instances whereinnerHTMLwas being directly assigned without sanitation.Ref.