Updating Mux video component #242
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/basement/next-typescript/86wDyVTS7Vx5sP6uiMXxj3mPnFui |
| setInView(() => { | ||
| return element.isIntersecting | ||
| }) |
There was a problem hiding this comment.
| setInView(() => { | |
| return element.isIntersecting | |
| }) | |
| setInView(element.isIntersecting) |
| if (options.triggerOnce) { | ||
| observer.unobserve(elm as unknown as Element) | ||
| } |
There was a problem hiding this comment.
NICE. por las dudas, probaste q esto funcione bien y no triggeree re-renders?
| if (options.triggerOnce) { | ||
| observer.unobserve(elm as unknown as Element) | ||
| } | ||
| cb(element) |
There was a problem hiding this comment.
ejecutamos el callback solo cuando isIntersecting === true? no se si es medio rari.
There was a problem hiding this comment.
hmm, si, hacía sentido en mi caso de uso pero mejor le pasamos el evento completo al cb y que haga lo que necesite con ese valor
|
@matiasperz Otra cosita: acá me gustaría que devuelva directamente el boolean, tipo Nos pasó en MrBeast q habíamos asumido q devolvía directamente el |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matiasperz
changed the title
Updates on
mux-video.tsx:Updates on
use-intersection-observer.ts: