WEBAPP-763: skip genome check if genome_id is null while pulling tagged files #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod HotFix-Adding-Missing-Policy-Method
…e chaining issues
making max duration assume role expiry to 1hr for cross cloud for rol…
blasvicco
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this PR:
Handle cases where a dependent child analysis does not have a defined genome.
When pulling tagged files for such analyses, the
genome_idwill be set toNULL. In some cases, like with Micronbrane, there is no single genome that can be defined for the sample, as it may be an assembly. In these situations, we still want to be able to pull the tagged files, even though a genome is not provided. To enable this, we need to skip the genome-related checks only when thegenome_idis not available, instead of treating it as an error condition.