Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qwen config and and input config simplification #1190

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Conversation

joostinyi
Copy link
Collaborator

@joostinyi joostinyi commented Oct 15, 2024

🚀 What

  • Adds QWEN support to TRTLLM build configuration
  • Removes max_input_len and max_output_len configuration in favor of max_seq_len
  • Adds defaults for max_batch_size and max_num_tokens

💻 How

🔬 Testing

@joostinyi
Copy link
Collaborator Author

once this lands we should get https://github.com/basetenlabs/docs.baseten.co/pull/99 out

@@ -75,7 +75,6 @@ class TrussTRTLLMBuildConfiguration(BaseModel):
plugin_configuration: TrussTRTLLMPluginConfiguration = (
TrussTRTLLMPluginConfiguration()
)
use_fused_mlp: bool = False
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to plugin config – defaulted to true

Copy link
Contributor

@bdubayah bdubayah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@joostinyi joostinyi merged commit 467b7a1 into main Oct 28, 2024
5 checks passed
@joostinyi joostinyi deleted the jyi/max-seq-len branch October 28, 2024 21:16
joostinyi added a commit to basetenlabs/truss-examples that referenced this pull request Oct 29, 2024
With newer versions of TRT-LLM and our engine builder, the
`max_input_len` and `max_output_len` configurations have been deprecated
in favor of `max_seq_len`. This PR should be landed after
basetenlabs/truss#1190 and the lock file should
be updated to pick up config changes from `truss` mainline. Passing run
[here](https://github.com/basetenlabs/truss-examples/actions/runs/11562846363/job/32188633491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants