Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for Smoke Tests #1296

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Prep for Smoke Tests #1296

merged 2 commits into from
Jan 7, 2025

Conversation

marius-baseten
Copy link
Contributor

🚀 What

  • Support override for USER_TRUSSRC_PATH with env var (for smoke testing).
  • Remove unneeded kwargs from TrussRemote.
  • Add HTTP status code to chained error logs.
  • Make GenericRemoteException so it can be used in user code execption handling.

💻 How

🔬 Testing

@marius-baseten marius-baseten requested review from squidarth and tyranitar and removed request for squidarth January 6, 2025 18:37
@@ -16,7 +17,7 @@
from truss.remote.baseten import BasetenRemote
from truss.remote.truss_remote import RemoteConfig, TrussRemote

USER_TRUSSRC_PATH = Path("~/.trussrc").expanduser()
USER_TRUSSRC_PATH = Path(os.environ.get("USER_TRUSSRC_PATH", "~/.trussrc")).expanduser()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@marius-baseten marius-baseten merged commit cd4e9c0 into main Jan 7, 2025
4 checks passed
@marius-baseten marius-baseten deleted the marius/smoke-prep branch January 7, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants