Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruff dependency version #1305

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Upgrade ruff dependency version #1305

merged 3 commits into from
Jan 10, 2025

Conversation

nnarayen
Copy link
Contributor

@nnarayen nnarayen commented Jan 10, 2025

🚀 What

Upgrades the dependency on ruff from 0.4.10 to 0.9.0. I've split the PR by commits:

  • First commit just updates the dependency
  • Second commit performs all the lint / formatting fixes

There are some expected changes to both source code format and autogenerated chains code format.

💻 How

🔬 Testing

f" {up_frame.code_context[0].strip()}" # type: ignore[index]
)
f" {up_frame.code_context[0].strip()}"
) # type: ignore[index]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this fail mypy now?

Copy link
Contributor Author

@nnarayen nnarayen Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline - for now we'll use the semi hacky # fmt directive to avoid this, and a followup will introduce a slightly different way to generate location so we don't have this issue

@nnarayen nnarayen merged commit 174bf94 into main Jan 10, 2025
4 checks passed
@nnarayen nnarayen deleted the nikhil/upgrade-ruff-version branch January 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants