Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trusted publishing #1320

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update trusted publishing #1320

merged 2 commits into from
Jan 17, 2025

Conversation

michaelfeil
Copy link
Contributor

@michaelfeil michaelfeil commented Jan 17, 2025 •
edited
Loading

🚀 What

  • I did setup trusted-publishing on PYPI
  • accidentally enabled it with push to main (sorry about that! Affects only main releases, not RC) (ba976f2)

After its
-> this PR fixes the rest, tests the workflow with RC version, which then should be good to go.

-> after we can evict "secrets.PYPI_PASSWORD" from the gh secrets (important!)

💻 How

🔬 Testing

@michaelfeil michaelfeil merged commit a9463e9 into main Jan 17, 2025
3 of 5 checks passed
@michaelfeil michaelfeil deleted the mf/update-trusted-publishing branch January 17, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-baseten marius-baseten marius-baseten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfeil @marius-baseten