Cleanup init and init_directory usage
#1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnarayen
force-pushed
the
nikhil/python-dx-init-cleanup
branch
from
96f800f to
350bdf6
Compare
nnarayen
commented
Feb 5, 2025
| @@ -205,14 +205,14 @@ def image(): | |||
| ) | |||
| @click.option("-n", "--name", type=click.STRING) | |||
| @click.option( | |||
| "--python-configuration/--no-python-configuration", | |||
| "--python-config/--no-python-config", | |||
There was a problem hiding this comment.
nnarayen
force-pushed
the
nikhil/python-dx-init-cleanup
branch
from
350bdf6 to
63bae66
Compare
nnarayen
commented
Feb 5, 2025
| assert spec.model_module_dir.exists() | ||
| assert spec.data_dir.exists() | ||
| assert spec.truss_dir == tmp_path | ||
| assert spec.config_path.exists() | ||
|
|
||
|
|
||
| def test_truss_init_with_data_file_and_requirements_file_and_bundled_packages(tmp_path): |
There was a problem hiding this comment.
Mentioned in this PR, but this was the only use case of passing data_files / requirements_file / bundled_packages into init. Since no real code uses it, it's safe to delete the test while we delete init in favor of init_directory
nnarayen
force-pushed
the
nikhil/python-dx-init-cleanup
branch
from
63bae66 to
170a4a4
Compare
marius-baseten
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
Small followup from this PR:
init, since it was only used in testsinit_directorydirectly, maintain coverage💻 How
🔬 Testing