Fix integration test for span cleanup #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnarayen
force-pushed
the
nikhil/fix-integration-test
branch
from
6537fb4 to
47bc00e
Compare
squidarth
approved these changes
Feb 7, 2025
nnarayen
commented
Feb 7, 2025
| @@ -824,7 +824,7 @@ async def __call__( | |||
| predict_result, | |||
| span_predict, | |||
| detached_ctx, | |||
| release_and_end=get_defer_fn(), | |||
| get_cleanup_fn=get_defer_fn, | |||
There was a problem hiding this comment.
Previously, we'd only request the defer_fn if we knew we were going to execute it explicitly, which prevents the default behavior of releasing the semaphore (and ending a span). My refactor unintentionally changed this behavior, so that we wouldn't release the semaphore if we invoked my new shared helper. Very lucky the integration test caught this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
A previous PR broke integration tests after unintentionally changing the behavior of semaphore cleanup code.
💻 How
🔬 Testing
now passes