Fix release script, derive current version from pypi #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnarayen
requested review from
marius-baseten and
squidarth
and removed request for
marius-baseten
nnarayen
force-pushed
the
nikhil/fix-release-script
branch
from
36b45ec to
33a1624
Compare
nnarayen
commented
Feb 13, 2025
| @@ -25,9 +25,15 @@ jobs: | |||
| run: | | |||
| curl -sSL https://install.python-poetry.org | python3 - | |||
|
|
|||
| - name: Get current Truss version | |||
There was a problem hiding this comment.
This should fetch the latest stable release (ignores rcs), regardless of yank status which is actually what we want. Therefore, it should be safe to rely on this as the current version number to bump from.
Closed
squidarth
approved these changes
Feb 13, 2025
marius-baseten
approved these changes
Feb 13, 2025
bin/bump_truss_version.sh
Outdated
| # ./bump_version.sh minor # bumps the minor version (resets patch to 0) | ||
| # ./bump_version.sh 0.9.60 # bumps the patch (micro) version by default | ||
| # ./bump_version.sh 0.9.60 major # bumps the major version (resets minor and patch to 0) | ||
| # ./bump_version.sh 0.9.60 minor # bumps the minor version (resets patch to 0) |
There was a problem hiding this comment.
Nit: Add expected new versions, just to be explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
My recent attempt to improve the release flow had a slight bug which caused us to skip a version number. The root cause is we create RCs off the next intended version, which my script didn't account for. Instead of trying to bake that logic into the script, I actually think it's better to derive the current version from PyPI rather than try to parse it from
pyproject.toml💻 How
🔬 Testing
Created #1394