Add truss patch flow tests for all python versions #205
Conversation
| th = TrussHandle(custom_model_control) | ||
| th.update_python_version(python_version) |
There was a problem hiding this comment.
I'm not super clear on what this is doing. What is it updating based on this python_version?
There was a problem hiding this comment.
This updated python version in truss_config, which in turn governs the python version on the docker image. Ultimately, this governs what python version users model code runs with.
There was a problem hiding this comment.
Gotcha. Does this only validate tests run in docker?
There was a problem hiding this comment.
Yes, these run with docker. What do you mean by only validate? These run the whole truss patch flow using the docker image built for truss which those versions.
There was a problem hiding this comment.
whole truss patch flow
I see. Makes sense if this is the only to test that flow. Ideally, we want to run all tests in both environments, but agreed this is a good stop gap for now.
Until we figure out a more through strategy, adding these tests to catch issues in control truss patch flow for all versions of python we support.